Cut 0.0.117 #2620
Merged
Cut 0.0.117 #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 89.09% 89.06% -0.03%
==========================================
Files 112 112
Lines 86959 86959
Branches 86959 86959
==========================================
- Hits 77475 77449 -26
- Misses 7258 7276 +18
- Partials 2226 2234 +8 ☔ View full report in Codecov by Sentry. |
tnull
reviewed
Sep 29, 2023
ariard
reviewed
Sep 30, 2023
| total, these changes should result in improved payment success rates at the | ||
| cost of slightly worse routefinding performance. | ||
| * Support for custom TLVs for recipients of HTLCs has been added (#2308). | ||
| * Support for generating transactions for third-party watchtowers has been |
There was a problem hiding this comment.
It can be noted justice transactions claiming only the revoked to_local, not potential revoked HTLC output or second-stage HTLC outputs, iirc #2337 changes.
There was a problem hiding this comment.
I think that's how ~all watchtowers work today.
TheBlueMatt
force-pushed
the
2023-09-cut-0.0.117
branch
from
89e1d91 to
147d736
Compare
|
Squashed the fixups and rebased 🎉 |
tnull
previously approved these changes
Oct 3, 2023
wpaulino
reviewed
Oct 3, 2023
TheBlueMatt
force-pushed
the
2023-09-cut-0.0.117
branch
from
147d736 to
c748746
Compare
|
Few minor spelling nits: $ git diff-tree -U1 147d736e c7487460
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9bff8a18c..a050afb72 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -63,5 +63,5 @@
## Backwards Compatibility
- * User migrating from `KVStorePersister` can use a concatentation of
- `[{primary_namespace}/[{secondary_namespace}/]]{key}` to build a compatible
- data when using the new `KVStore` persistence interface (#2472).
+ * Users migrating to the new `KVStore` can use a concatentation of
+ `[{primary_namespace}/[{secondary_namespace}/]]{key}` to build a key
+ compatible with the previous `KVStorePersister` interface (#2472).
* Downgrading after receipt of a payment with custom HTLC TLVs may result in
@@ -76,3 +76,3 @@
* First, make a backup copy of all channel state,
- * Then ensure all `ChannelMonitorUpdate`s stored are fully applied to the
+ * then ensure all `ChannelMonitorUpdate`s stored are fully applied to the
relevant `ChannelMonitor`,
@@ -83,3 +83,3 @@
commitment transaction (i.e. force-closing) would previously not generate a
- `SpendableOutputs` event for the `to_local` (i.e. non-HTLC-encumbered)
+ `SpendableOutputs` event for our `to_remote` (i.e. non-HTLC-encumbered)
balance. Those with such balances available should fetch the missing
$ |
tnull
approved these changes
Oct 3, 2023
valentinewallace
approved these changes
Oct 3, 2023
wpaulino
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.